Document: draft-ietf-bfd-secure-sequence-numbers-24.txt
Reviewer: Acee Lindem
Review Date: 08/29/2025
IETF LC End Date: N/A
Intended Status: Experimental

Result: Not Ready (although it should be very easy to fix)

This is YANG doctor review on the YANG model ietf-bfd-met-keyed-isaac.yang.

The following issues have to be addressed:

   1. The first use of the acronym ISAAC should be expanded in the YANG data
        module (and also the draft).
   2. The prefix should be "bfdmki" for "BFD Meticulously Keyed ISAAC" rather than
      "bfdmia" for "BFD Missing In Action". I guess this refers to the selection of the
       YANG data module prefix? 
   3. The identities optimized-md5-meticulous-keyed-isaac and
      optimized-md5-meticulous-keyed-isaac must be removed from
      ietf-bfd-opt-auth.yang as they are now in this YANG data module.
   4. The "Security Considerations" section of the draft is missing the
      YANG boilerplate for the YANG model described in the draft.

Consider:

   1. Should each optimized authentication method have its own YANG feature rather
      than a single one for "optimized-auth? If not, maybe keep a single YANG model
      ietf-bfd-opt-auth.yang with a reference to this draft (as long as both drafts progress
      together). 


Thanks,
Acee