IoT Review of draft-ietf-core-yang-sid-pen-04

Reviewer: Ines Robles

The draft defines a method for allocating YANG Schema Item Identifiers (SIDs) to organizations that hold Private Enterprise Numbers (PENs). The allocation derives the actual SID ranges from the PEN number, providing a standardized way to assign SID ranges to PEN holders based on their PEN values.

Overall, the draft is well written. I have some minor comments and suggestions below.

Comments:

1. The draft defines two SID allocations based on PEN value (63-bit SIDs and SIDs whose numeric values fit within 32 bits). For PEN values below 100,000, such as 30810, both allocation rules could apply.

1.1 It is unclear from the current text whether the PEN holder receives both SID ranges simultaneously, which would give organizations with PEN < 100,000 more SIDs than those with PEN ≥ 100,000.

1.2 Alternatively, it is unclear whether the PEN holder must choose only one range, and

1.3 if so, whether one range is considered preferred over the other.

2. Are there any privacy considerations in this draft?

Nits

3. "The larger of the two spaces uses 64-bit numbers". -->" The larger of the two spaces requires a 64-bit representation".?

4. "...first 100,000 holders" --> "...PEN values from 0–99,999" ? //unambiguously defines the numerical range of PENs, regardless of registration order.

5. "...32-bit SIDs" --> "...SIDs whose numeric values fit within 32 bits"? // to avoid confusion, since SIDs are  63-bit identifiers.


Thanks for this document,


Ines.