Here is my YANG doctor's review of draft-ietf-netconf-distributed-notif-13.

From a pure YANG perspective, this module is trivial.  I just have two minor comments:

o  pyang --ietf complains that the module description doesn't contain
   the (correct) IETF Trust Copyright statement.

   "Simplified BSD License" should be "Revised BSD License"

o  You have "leaf-list message-publisher-ids".  By convention, lists and leaf-lists normally
   have names in singular ("leaf-list message-publisher-id")



As for the document as a whole, I have some concerns.  It is not at
all clear to me which problem this document tries to solve, and the
document feels unfinished.  The title of the draft is "Subscription to
Distributed Notifications", but there is no definition of a
"distributed notification".

What is a "Component Subscription"?  Is it a NETCONF subscription or
something else?

Why is the "message-pubslisher-id" an unsigned integer?  As a client,
I am presented with a set of unsigned integers with no further
explanation.  What is the client supposed to do with this information?

Section 5 says:

   The Collector can only subscribe to the Master.  This requires the
   Publisher Master to:

   1.  expose the Global Capability that can be served by multiple
       Publisher Agents;

What does this requirement mean?  What is the Global Capability that
must be exposed, and how is it exposed?

At this point, I am quite confused.

To me, the proposed changes seem to be very implementation specific.

Section 12 lists some projects that supposedly implement this draft.
I downloaded the three open source projects listed in sections 12.1,
12.2 and 12.3 to see if I could understand more about how this draft
could be used, but as far as I could tell, these projects do not actually
implement this draft.


/martin